Bix/eden
1
0
Fork 0
mirror of https://git.eden-emu.dev/eden-emu/eden.git synced 2025-10-18 07:17:53 +00:00
Code Issues Projects Releases Packages Wiki Activity Actions

file-sys: Default heavy-weight class destructors in the cpp file

Browse source 
Several classes have a lot of non-trivial members within them, or don't
but likely should have the destructor defaulted in the cpp file for
future-proofing/being more friendly to forward declarations.

Leaving the destructor unspecified allows the compiler to inline the
destruction code all over the place, which is generally undesirable from
a code bloat perspective.
This commit is contained in:
Lioncash 2018-09-19 19:19:05 -04:00
parent bd66646f8b
commit 315f6ef402
25 changed files with 45 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

2
src/core/file_sys/content_archive.h
View file

@ -81,6 +81,8 @@ class NCA : public ReadOnlyVfsDirectory {
public:
explicit NCA(VirtualFile file, VirtualFile bktr_base_romfs = nullptr,
u64 bktr_base_ivfc_offset = 0);
~NCA() override;
Loader::ResultStatus GetStatus() const;
std::vector<std::shared_ptr<VfsFile>> GetFiles() const override;