From 12b32a058b631871548135eb56fa49e150b5ef20 Mon Sep 17 00:00:00 2001 From: Lioncash Date: Wed, 5 Jun 2019 15:47:42 -0400 Subject: [PATCH] yuzu/CMakeLists: Disable unsafe overloads of QProcess' start() function Other overloads of start() are considerably much safer to use if we ever need this in the future and need to pass arguments to the program, given it contains separate parameters for the program path and the arguments themselves, whereas this unsafe overload contains both as a single string. Given the alternatives are much safer, we can disable this. --- src/yuzu/CMakeLists.txt | 3 +++ 1 file changed, 3 insertions(+) diff --git a/src/yuzu/CMakeLists.txt b/src/yuzu/CMakeLists.txt index ec969a9a74..37394be377 100644 --- a/src/yuzu/CMakeLists.txt +++ b/src/yuzu/CMakeLists.txt @@ -162,6 +162,9 @@ target_compile_definitions(yuzu PRIVATE # Disable implicit type narrowing in signal/slot connect() calls. -DQT_NO_NARROWING_CONVERSIONS_IN_CONNECT + + # Disable unsafe overloads of QProcess' start() function. + -DQT_NO_PROCESS_COMBINED_ARGUMENT_START ) if (YUZU_ENABLE_COMPATIBILITY_REPORTING)